fix: Laravel 12.45.x ResourceCollection compatibility#482
Merged
Conversation
Laravel 12.45.0 introduced a breaking change in ResourceCollection handling (PR laravel/framework#58299). Collections created from plain arrays no longer work correctly. Fix: Wrap array in collect() to ensure proper Collection type. Related: #479, #480, #481, #478 (Dependabot PRs)
💡 Tip: Consider Using Draft PRsBenefits of opening PRs as drafts initially:
How to convert:
This is just a friendly reminder - feel free to continue as is! 😊 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a test failure caused by Laravel 12.45.0's breaking change in ResourceCollection handling, which now requires proper Collection types instead of plain arrays for correct data transformation.
Key Changes
- Wraps test array in
collect()to ensureSecretAttachmentResource::collection()receives an Eloquent Collection instead of a plain array - Maintains compatibility with Laravel 12.45.x while preserving test functionality
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes test failures in all Dependabot PRs (#478, #479, #480, #481) caused by Laravel 12.45.0 breaking change in
ResourceCollectionhandling.Problem
Laravel 12.45.0 introduced PR #58299 which changed how
ResourceCollection::collection()handles plain arrays vs Model Collections. The testSecretAttachmentResourceTest > resource transforms collection correctlywas passing a plain array, which now returns incorrect data structure.Failing Test:
Error:
Solution
Wrap the array in
collect()to ensure proper Collection type:This ensures the ResourceCollection receives an Eloquent Collection instead of a plain array, maintaining compatibility with Laravel 12.45.x.
Testing
Impact
Related
ResourceCollectionusage when used with an array instead of Model collection laravel/framework#58299