Conversation
This was referenced Apr 13, 2024
Owner
Author
|
@codebude Along with supporting SVG and PDF files on Linux, adding support for base64-encode PNG files is rather simple; PNG is the default encoder for Base64QRCode anyway. It also provides a notable performance optimization for base64-encoded PNG files regardless of platform. |
codebude
reviewed
Apr 24, 2024
Owner
Author
|
I've made suggestions based on your comments; please review again @codebude - thanks! |
Collaborator
|
@Shane32 looks good. Reminder to myself: update change log and compatibility matrix. |
Collaborator
Collaborator
|
Hi @aligneddev
Yesterday! Joking aside, there is only one open PR (#503) left, which I would like to review and merge, before I release the next version (1.5.0). So if nothing unforseen happens, you can expect the release within the next 2-3 days. |
This was referenced Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows
Base64QRCodeto be used with .NET 6+ on Linux as long as the requested image type is PNG.Test plan
Tests have been added to the codebase
Closing issues
Fixes: