Conversation
Owner
Author
|
I don't know why these tests pass. EDIT: fixed now; generator polynomial is duplicated so the original doesn't change |
Owner
Author
|
Just for fun, I've added another benchmark for a 2600-character QR code and compared this PR against v1.5.1. For these unreasonably-long QR codes, memory requirements have been reduced from 110 MB to 114 KB, a 99.9% reduction. And there's still room for improvement. Version 1.5.1
This PR
|
gfoidl
reviewed
May 9, 2024
Co-authored-by: Günther Foidl <gue@korporal.at>
Owner
Author
|
Thanks @gfoidl ! I'll merge in your suggestions here later tonight. |
This was referenced Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves performance by calculating
generatorPolynomonly a single time and renting arrays fromArrayPool. Basically I rewrotePolynomto function similar toList<PolynomItem>with methods such asAdd,ClearandSort. It's a struct so it does not require a heap allocation itself (no change), and the underlying buffer is rented from the array pool. CallingDisposeon thePolynomwill return the array back to the array pool.Before
After - via ArrayPool.Shared
After - via custom array pool implementation (for use with .NET Framework)