Split alphanumeric encoding from QRCodeGenerator, split encoding tables#590
Conversation
Shane32
changed the title
Shane32
changed the title
Shane32
commented
Apr 7, 2025
Shane32
commented
Apr 7, 2025
Shane32
commented
Apr 7, 2025
Shane32
commented
Apr 7, 2025
Shane32
commented
Apr 7, 2025
Owner
Author
|
@codebude Ready for review please. This is pretty basic refactoring, further code-splitting |
gfoidl
approved these changes
Apr 15, 2025
Collaborator
gfoidl
left a comment
gfoidl
left a comment
There was a problem hiding this comment.
Just a little calc-simplification, otherwise LGTM (codewise, I don't know these constants good enough to judge about them).
Co-authored-by: Günther Foidl <gue@korporal.at>
Shane32
commented
Apr 16, 2025
codebude
approved these changes
Jun 2, 2025
Collaborator
Shane32
added
the
refactoring
This was referenced Oct 9, 2025
This was referenced Nov 25, 2025
This was referenced Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring for readability, maybe as prep to add Micro QR code support; no functional changes; no public API changes. Also made a few other inconsequential changes; see notes below.
Note that tests are not all passing locally for me anymore, probably due to PNG encoding not being stable across .NET versions/frameworks