Avoid failing if the git extension is disabled #3822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
egiurleo
approved these changes
Nov 13, 2025
Merge activity
|
### Motivation Closes #3685 If the git extension is disabled, trying to invoke `getAPI` may throw an error like the one reported in the issue. ### Implementation We can just wrap that call in a try/catch block since we fall back to the default, which is to consider the git root to be in the same place as the workspace path.
graphite-app
bot
force-pushed
the
11-12-avoid_failing_if_the_git_extension_is_disabled
branch
from
bd002e1 to
abd88c8
Compare
graphite-app
bot
deleted the
11-12-avoid_failing_if_the_git_extension_is_disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3685
If the git extension is disabled, trying to invoke
getAPImay throw an error like the one reported in the issue.Implementation
We can just wrap that call in a try/catch block since we fall back to the default, which is to consider the git root to be in the same place as the workspace path.