Feature/angular query

[arnoud-dv]

Experimental Angular adapter

Uses signals, will support Angular 17+

The Svelte adapter served as a very good base, thanks! ❤️

Feedback is very welcome! Contact me on the Tanstack Discord in the angular-query channel or in this Github discussion.

To do

• react to attribute changes of dev tools
• find a solution for dev tools needing "skipLibCheck": true setting in app using them
• reduce boilerplate for options signals
• redo dependency injection and providers
  • improve query client mounting and unmounting
  • inject* functions such as injectQuery
• injectInfiniteQuery
• injectMutationState
• docs
• update unit tests to use the new function based API
• more unit tests
• more examples
• integration test

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)	Visit Preview		Dec 1, 2023 0:42am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2af306d:

Sandbox	Source
@tanstack/query-example-angular-basic	Configuration
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

[ApplY3D]

Should we add the possibility to pass an Observable into the queryKey? Great things are now available with signals, but we still have observables.

[ApplY3D]

for example:

queryKey: ['post', this.postId$]
// or
queryKey: this.postId$.pipe(map(id => ['post', id]))

[ApplY3D]

Also other props like enabled might be reactive. Probably injectQuery itself should be able to receive Observable

[arnoud-dv]

Hi, what do you think about using toSignal()?

queryKey: ['post', toSignal(this.postId$)]

Would that be sufficient? Willing to look into adding first class support for observables if many people want it but on the other hand it might increase complexity quite a bit and Angular has good interop between observables and signals.

[ApplY3D]

Yes, it might suffice, but it needs to be tested in real situations for potential leaks or other issues.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2af306d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx affected --targets=test:eslint,test:lib,test:types,test:build,test:bundle

---

Sent with 💌 from NxCloud.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 90.42553% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.83%. Comparing base (af0ff9a) to head (2af306d).
⚠️ Report is 1563 commits behind head on main.

Files with missing lines	Patch %	Lines
...ages/angular-query-experimental/src/query-proxy.ts	52.94%	8 Missing ⚠️
...s/angular-query-experimental/src/injectMutation.ts	94.11%	1 Missing ⚠️

❌ Your project status has failed because the head coverage (87.83%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff            @@
##           main    #6195       +/-   ##
=========================================
+ Coverage      0   87.83%   +87.83%     
=========================================
  Files         0       87       +87     
  Lines         0     2926     +2926     
  Branches      0      803      +803     
=========================================
+ Hits          0     2570     +2570     
- Misses        0      297      +297     
- Partials      0       59       +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.