Skip to content

feat: add generic type to SegmentedControl#9160

Merged
BlackySoul merged 1 commit intomasterfrom
blackysoul/8760/fix_types
Nov 14, 2025
Merged

feat: add generic type to SegmentedControl#9160
BlackySoul merged 1 commit intomasterfrom
blackysoul/8760/fix_types

Conversation

@BlackySoul
Copy link
Contributor


  • Release notes

Описание

Изменения

Убрала возможность в явном виде указывать undefined в качестве value в options, потому что нарушается требование контролируемого/неконтролируемого компонента

Release notes

Улучшения

  • SegmentedControl: улучшено выведение типов

@BlackySoul BlackySoul requested a review from a team as a code owner November 13, 2025 16:30
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 421.06 KB (0%)
JS (gzip) 128.01 KB (0%)
JS (brotli) 104.79 KB (0%)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.48 KB (0%)
CSS (gzip) 45.84 KB (0%)
CSS (brotli) 36.39 KB (0%)

@github-actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (2abc174) to head (c2df90f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9160   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         420      420           
  Lines       11184    11184           
  Branches     4210     4210           
=======================================
  Hits        10628    10628           
  Misses        556      556           
Flag Coverage Δ
unittests 95.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit c2df90f

@github-actions
Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9160/c2df90fdb0929ee5e6256870b3a9f851df2c0fa3/pkg/@vkontakte/vkui/_pkg.tgz

Commit c2df90f

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BlackySoul BlackySoul merged commit 436ba3f into master Nov 14, 2025
29 checks passed
@BlackySoul BlackySoul deleted the blackysoul/8760/fix_types branch November 14, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Доработать SegmentedControl для работы с Generic

3 participants