feat(Switch,Checkbox,Radio): move restProps to root#9180
Merged
EldarMuhamethanov merged 5 commits intomasterfrom Nov 19, 2025
Merged
feat(Switch,Checkbox,Radio): move restProps to root#9180EldarMuhamethanov merged 5 commits intomasterfrom
EldarMuhamethanov merged 5 commits intomasterfrom
Conversation
…move-rest # Conflicts: # packages/vkui/src/components/Checkbox/Checkbox.tsx
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9180/b98962e57adb79418e1715cca09503573bcf2521/pkg/@vkontakte/vkui/_pkg.tgzCommit b98962e |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9180 +/- ##
=======================================
Coverage 95.02% 95.03%
=======================================
Files 419 420 +1
Lines 11183 11190 +7
Branches 4210 4212 +2
=======================================
+ Hits 10627 10634 +7
Misses 556 556
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EldarMuhamethanov
deleted the
e.muhamethanov/9043/switch-radio-checkbox-move-rest
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch,Radio/RadioInput,Checkbox/CheckboxInput#9043Описание
Нужно перенести restProps, из внутреннего инпута в корень компонента. Также некоторые свойства должны остаться для инпута, эти свойства описаны в #9043
Release notes
BREAKING CHANGE
Switch,Radio/RadioInput,Checkbox/CheckboxInput#9043, прокидываются в корень компонентаSwitch,Radio/RadioInput,Checkbox/CheckboxInput#9043, прокидываются в корень компонентаSwitch,Radio/RadioInput,Checkbox/CheckboxInput#9043, прокидываются в корень компонента