Skip to content

feat(CustomSelect,NativeSelect): move restProps to root#9185

Merged
EldarMuhamethanov merged 4 commits intomasterfrom
e.muhamethanov/9045/select-move-rest-props
Nov 19, 2025
Merged

feat(CustomSelect,NativeSelect): move restProps to root#9185
EldarMuhamethanov merged 4 commits intomasterfrom
e.muhamethanov/9045/select-move-rest-props

Conversation

@EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Nov 19, 2025


  • Unit-тесты
  • Документация фичи
  • Release notes

Описание

Нужно перенести restProps, из внутреннего инпута в корень компонента. Также некоторые свойства должны остаться для инпута, эти свойства описаны в #9045

Release notes

BREAKING CHANGE

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 19, 2025 06:59
@EldarMuhamethanov EldarMuhamethanov changed the title E.muhamethanov/9045/select move rest props feat(CustomSelect,NativeSelect): move restProps to root Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

size-limit report 📦

Path Size
JS 421.56 KB (+0.07% 🔺)
JS (gzip) 128.16 KB (+0.04% 🔺)
JS (brotli) 105 KB (-0.03% 🔽)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.43 KB (0%)
CSS (gzip) 45.83 KB (0%)
CSS (brotli) 36.31 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 67484ae

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9185/67484ae61e8d206a763fba081c8d548dfc6ef7b9/pkg/@vkontakte/vkui/_pkg.tgz

Commit 67484ae

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (c55d7cb) to head (67484ae).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9185   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         419      419           
  Lines       11183    11183           
  Branches     4210     4210           
=======================================
  Hits        10627    10627           
  Misses        556      556           
Flag Coverage Δ
unittests 95.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

фуууух было потно 🥵

апрув 🚀 👍

@EldarMuhamethanov EldarMuhamethanov merged commit 3de1954 into master Nov 19, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/9045/select-move-rest-props branch November 19, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE][restProps]: перенести в корневой элемент у NativeSelect, CustomSelect, Select

2 participants