Skip to content

feat(Banner): add imageTheme="auto" and set it as default#9188

Merged
EldarMuhamethanov merged 1 commit intomasterfrom
e.muhamethanov/8758/banner-image-theme-auto
Nov 19, 2025
Merged

feat(Banner): add imageTheme="auto" and set it as default#9188
EldarMuhamethanov merged 1 commit intomasterfrom
e.muhamethanov/8758/banner-image-theme-auto

Conversation

@EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Документация фичи
  • Release notes

Описание

Нужно изменить цвет текста и иконок компонента Banner в режиме image в соответствии с #8758. Новые цвета теперь не зависят от цветовой схемы приложения, из-за чего это изменение является ломающим обратную совместимость. Для того, чтобы исправить ситуацию, добавил в imageThemeсо значением auto. В этом режиме imageTheme рассчитывается от цветовой схемы приложения.

Release notes

Улучшения

  • Banner: В свойстве imageTheme добавлено значение auto для того, чтобы imageTheme определялось автоматически, в зависимости от цветовой схемы приложения.

BREAKING CHANGE

  • Banner: По умолчанию теперь свойство imageTheme="auto"

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 19, 2025 12:07
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 421.72 KB (-0.41% 🔽)
JS (gzip) 128.27 KB (-0.24% 🔽)
JS (brotli) 105.1 KB (-0.17% 🔽)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.5 KB (+0.02% 🔺)
CSS (gzip) 45.84 KB (+0.02% 🔺)
CSS (brotli) 36.32 KB (+0.04% 🔺)

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit e0e4f8c

@github-actions
Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9188/e0e4f8cd2d49bf3a54aea6b4dbae2068ce5f3e55/pkg/@vkontakte/vkui/_pkg.tgz

Commit e0e4f8c

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.04%. Comparing base (c55d7cb) to head (e0e4f8c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9188      +/-   ##
==========================================
+ Coverage   95.02%   95.04%   +0.01%     
==========================================
  Files         419      419              
  Lines       11183    11185       +2     
  Branches     4210     4211       +1     
==========================================
+ Hits        10627    10631       +4     
+ Misses        556      554       -2     
Flag Coverage Δ
unittests 95.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@EldarMuhamethanov EldarMuhamethanov merged commit 293757f into master Nov 19, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8758/banner-image-theme-auto branch November 19, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants