feat(Banner): add imageTheme="auto" and set it as default#9188
Merged
EldarMuhamethanov merged 1 commit intomasterfrom Nov 19, 2025
Merged
feat(Banner): add imageTheme="auto" and set it as default#9188EldarMuhamethanov merged 1 commit intomasterfrom
EldarMuhamethanov merged 1 commit intomasterfrom
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9188/e0e4f8cd2d49bf3a54aea6b4dbae2068ce5f3e55/pkg/@vkontakte/vkui/_pkg.tgzCommit e0e4f8c |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9188 +/- ##
==========================================
+ Coverage 95.02% 95.04% +0.01%
==========================================
Files 419 419
Lines 11183 11185 +2
Branches 4210 4211 +1
==========================================
+ Hits 10627 10631 +4
+ Misses 556 554 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imageThemeприmode="image"не соответствует описанию в JSDoc #8758Описание
Нужно изменить цвет текста и иконок компонента
Bannerв режимеimageв соответствии с #8758. Новые цвета теперь не зависят от цветовой схемы приложения, из-за чего это изменение является ломающим обратную совместимость. Для того, чтобы исправить ситуацию, добавил вimageThemeсо значениемauto. В этом режимеimageThemeрассчитывается от цветовой схемы приложения.Release notes
Улучшения
imageThemeдобавлено значениеautoдля того, чтобыimageThemeопределялось автоматически, в зависимости от цветовой схемы приложения.BREAKING CHANGE
imageTheme="auto"