feat(DateRangeInput,DateInput,Calendar,CalendarRange): change onChange prop type#9195
Merged
EldarMuhamethanov merged 3 commits intomasterfrom Nov 26, 2025
Merged
Conversation
16 tasks
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9195/aa290533e4f8bf60dcda6afcf3af35dc52e0aae3/pkg/@vkontakte/vkui/_pkg.tgzCommit aa29053 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9195 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 420 420
Lines 11200 11204 +4
Branches 4217 4216 -1
=======================================
+ Hits 10645 10649 +4
Misses 555 555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inomdzhon
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO [>=8]#8972Описание
Нужно поменять тип
onChangeв компонентах с календарями(DateRangeInput,DateInput,Calendar,CalendarRange).Изменения
Calendarпоменял типonChangeна(value: Date) => voidтак как по идее вCalendarвonChangeне может прийтиnullилиundefinedCalendarRangeпоменял типonChangeна(value: DateRangeType) => voidтак как по идее вCalendarRangeвonChangeне может прийтиnullилиundefinedDateInputпоменял типonChangeна(value: Date | null) => void;так как в value не может прийтиundefinedDateRangeInputпоменял типonChangeна(value: DateRangeType | null) => void;так как вvalueне может прийтиundefinedRelease notes
BREAKING CHANGE
onChangeна(value?: Date) => void.onChangeна(value?: Date) => void.onChangeна(value: DateRangeType | null) => void. Теперьvalueможет бытьnullпри сбросе выбранного промежутка датonChangeна(value: DateRangeType | null) => void. Теперьvalueможет бытьnullпри сбросе выбранного промежутка дат