Skip to content

feat(DateRangeInput,DateInput,Calendar,CalendarRange): change onChange prop type#9195

Merged
EldarMuhamethanov merged 3 commits intomasterfrom
e.muhamethanov/8972/calendars-onchange-prop-type
Nov 26, 2025
Merged

feat(DateRangeInput,DateInput,Calendar,CalendarRange): change onChange prop type#9195
EldarMuhamethanov merged 3 commits intomasterfrom
e.muhamethanov/8972/calendars-onchange-prop-type

Conversation

@EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Nov 21, 2025


  • Unit-тесты
  • Release notes

Описание

Нужно поменять тип onChange в компонентах с календарями(DateRangeInput,DateInput,Calendar,CalendarRange).

Изменения

  • для Calendar поменял тип onChange на (value: Date) => void так как по идее в Calendar в onChange не может прийти null или undefined
  • для CalendarRange поменял тип onChange на (value: DateRangeType) => void так как по идее в CalendarRange в onChange не может прийти null или undefined
  • для DateInput поменял тип onChange на (value: Date | null) => void; так как в value не может прийти undefined
  • для DateRangeInput поменял тип onChange на (value: DateRangeType | null) => void; так как в value не может прийти undefined

Release notes

BREAKING CHANGE

  • Calendar: Изменен тип свойства onChange на (value?: Date) => void.
  • DateInput: Изменен тип свойства onChange на (value?: Date) => void.
  • CalendarRange: Изменен тип свойства onChange на (value: DateRangeType | null) => void. Теперь value может быть null при сбросе выбранного промежутка дат
  • DateRangeInput: Изменен тип свойства onChange на (value: DateRangeType | null) => void. Теперь value может быть null при сбросе выбранного промежутка дат

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

size-limit report 📦

Path Size
JS 426.41 KB (-0.03% 🔽)
JS (gzip) 129.04 KB (-0.02% 🔽)
JS (brotli) 105.5 KB (-0.1% 🔽)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.5 KB (0%)
CSS (gzip) 45.84 KB (0%)
CSS (brotli) 36.32 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit aa29053

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9195/aa290533e4f8bf60dcda6afcf3af35dc52e0aae3/pkg/@vkontakte/vkui/_pkg.tgz

Commit aa29053

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.04%. Comparing base (a32d9e5) to head (aa29053).
⚠️ Report is 113 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/lib/date.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9195   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         420      420           
  Lines       11200    11204    +4     
  Branches     4217     4216    -1     
=======================================
+ Hits        10645    10649    +4     
  Misses        555      555           
Flag Coverage Δ
unittests 95.04% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft November 21, 2025 11:02
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review November 25, 2025 07:54
@inomdzhon inomdzhon moved this to 👀 In Review in VKUI Nov 26, 2025
@EldarMuhamethanov EldarMuhamethanov merged commit f4632ce into master Nov 26, 2025
28 of 29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8972/calendars-onchange-prop-type branch November 26, 2025 15:15
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Nov 26, 2025
@inomdzhon inomdzhon added the v8 label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants