Skip to content

BREAKING CHANGE: rm baseClassName & baseStyle#9214

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/issue3430
Dec 19, 2025
Merged

BREAKING CHANGE: rm baseClassName & baseStyle#9214
SevereCloud merged 1 commit intomasterfrom
SevereCloud/issue3430

Conversation

@SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Nov 25, 2025


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Делаем свойства baseClassName и baseStyle приватными

Изменения

Правим типизацию

Release notes

BREAKING CHANGE

  • Свойства baseClassName и baseStyle были удалены

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

size-limit report 📦

Path Size
JS 402.41 KB (-0.01% 🔽)
JS (gzip) 123.5 KB (-0.02% 🔽)
JS (brotli) 102.27 KB (-0.08% 🔽)
JS import Div (tree shaking) 811 B (0%)
CSS 372.71 KB (0%)
CSS (gzip) 46.21 KB (0%)
CSS (brotli) 36.59 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit a3d88ec

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9214/a3d88ece07d42645d5334d260eeded5d020cc13c/pkg/@vkontakte/vkui/_pkg.tgz

Commit a3d88ec

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (cd814c7) to head (a3d88ec).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9214   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         427      427           
  Lines       11518    11518           
  Branches     4284     4284           
=======================================
  Hits        10943    10943           
  Misses        575      575           
Flag Coverage Δ
unittests 95.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 3, 2025
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 12, 2025
@inomdzhon inomdzhon added this to the v8.0.0 milestone Dec 17, 2025
@inomdzhon inomdzhon added this to VKUI Dec 17, 2025
@inomdzhon inomdzhon added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 17, 2025
@SevereCloud SevereCloud force-pushed the SevereCloud/issue3430 branch from fbee107 to a3d88ec Compare December 19, 2025 08:17
@SevereCloud SevereCloud marked this pull request as ready for review December 19, 2025 08:17
@SevereCloud SevereCloud requested a review from a team as a code owner December 19, 2025 08:17
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SevereCloud SevereCloud merged commit 94fed3f into master Dec 19, 2025
34 of 46 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue3430 branch December 19, 2025 09:59
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Dec 19, 2025
@inomdzhon inomdzhon added the v8 label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-stale Добавляет PR в исключения для автоматического закрытия

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants