Skip to content

feat(PopoutWrapper): remove fixed prop#9232

Merged
EldarMuhamethanov merged 4 commits intomasterfrom
e.muhamethanov/popout-wrapper-remove-fixed
Dec 1, 2025
Merged

feat(PopoutWrapper): remove fixed prop#9232
EldarMuhamethanov merged 4 commits intomasterfrom
e.muhamethanov/popout-wrapper-remove-fixed

Conversation

@EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Release notes

Описание

  • Выпилил свойство fixed. Сделал, чтобы по умолчанию свойство strategy было со значением fixed
  • Написал кодмоды для удаления свойства fixed

Release notes

BREAKING CHANGE

  • PopoutWrapper: свойство fixed было удалено. Вместо него можно использовать свойство strategy
    Примеры правильной миграции:
    <PopoutWrapper
      closing={closing}
      onClick={close}
    - fixed={false}
    + strategy="none"
    >
    
    </PopoutWrapper>
    <PopoutWrapper
      closing={closing}
      onClick={close}
    - fixed
    >
    
    </PopoutWrapper>

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

size-limit report 📦

Path Size
JS 426.91 KB (-0.03% 🔽)
JS (gzip) 129.32 KB (-0.03% 🔽)
JS (brotli) 105.73 KB (-0.11% 🔽)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (0%)
CSS (gzip) 45.92 KB (0%)
CSS (brotli) 36.4 KB (0%)

inomdzhon
inomdzhon previously approved these changes Nov 28, 2025
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 1de067d

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9232/1de067d3ea4bfadccaf4b4f8bb0ab9be387debf3/pkg/@vkontakte/vkui/_pkg.tgz

Commit 1de067d

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.06%. Comparing base (8a3fb4d) to head (1de067d).
⚠️ Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9232      +/-   ##
==========================================
- Coverage   95.06%   95.06%   -0.01%     
==========================================
  Files         421      421              
  Lines       11245    11243       -2     
  Branches     4225     4224       -1     
==========================================
- Hits        10690    10688       -2     
  Misses        555      555              
Flag Coverage Δ
unittests 95.06% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EldarMuhamethanov EldarMuhamethanov merged commit ad6b59f into master Dec 1, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/popout-wrapper-remove-fixed branch December 1, 2025 12:04
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Dec 1, 2025
@inomdzhon inomdzhon added the v8 label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants