feat(PopoutWrapper): remove fixed prop#9232
Merged
EldarMuhamethanov merged 4 commits intomasterfrom Dec 1, 2025
Merged
Conversation
16 tasks
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9232/1de067d3ea4bfadccaf4b4f8bb0ab9be387debf3/pkg/@vkontakte/vkui/_pkg.tgzCommit 1de067d |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9232 +/- ##
==========================================
- Coverage 95.06% 95.06% -0.01%
==========================================
Files 421 421
Lines 11245 11243 -2
Branches 4225 4224 -1
==========================================
- Hits 10690 10688 -2
Misses 555 555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inomdzhon
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO [>=8]#8972Описание
fixed. Сделал, чтобы по умолчанию свойствоstrategyбыло со значениемfixedfixedRelease notes
BREAKING CHANGE
fixedбыло удалено. Вместо него можно использовать свойствоstrategyПримеры правильной миграции:
<PopoutWrapper closing={closing} onClick={close} - fixed={false} + strategy="none" > </PopoutWrapper><PopoutWrapper closing={closing} onClick={close} - fixed > </PopoutWrapper>