Skip to content

BREAKING CHANGE: changing an uncontrolled input to be controlled#9246

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/BREAKING-CHANGE/changing-an-uncontrolled-input-to-be-controlled
Dec 3, 2025
Merged

BREAKING CHANGE: changing an uncontrolled input to be controlled#9246
SevereCloud merged 1 commit intomasterfrom
SevereCloud/BREAKING-CHANGE/changing-an-uncontrolled-input-to-be-controlled

Conversation

@SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Dec 2, 2025


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Так как мы не можем взаимодействовать с ref-ом во время рендеринга пришлось избавится от костыля при переключении контролируемого и некотролирумого состяния

Release notes

BREAKING CHANGE

@SevereCloud SevereCloud requested a review from a team as a code owner December 2, 2025 07:52
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

size-limit report 📦

Path Size
JS 426.32 KB (-0.02% 🔽)
JS (gzip) 129.09 KB (-0.02% 🔽)
JS (brotli) 105.57 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (0%)
CSS (gzip) 45.92 KB (0%)
CSS (brotli) 36.4 KB (0%)

@SevereCloud SevereCloud self-assigned this Dec 2, 2025
@SevereCloud SevereCloud added this to VKUI Dec 2, 2025
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.09%. Comparing base (b3f5483) to head (c45c3da).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9246   +/-   ##
=======================================
  Coverage   95.08%   95.09%           
=======================================
  Files         419      419           
  Lines       11210    11205    -5     
  Branches     4215     4213    -2     
=======================================
- Hits        10659    10655    -4     
+ Misses        551      550    -1     
Flag Coverage Δ
unittests 95.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit c45c3da

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9246/c45c3da97df032d5b1f37e1d43e3a4b924f42ba5/pkg/@vkontakte/vkui/_pkg.tgz

Commit c45c3da

@inomdzhon inomdzhon added this to the v8.0.0 milestone Dec 2, 2025
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мы можем дать рекомендацию в документе по миграции как нужно переписать применение компонента ChipsInput / ChipsSelect, который потенциально "сломается" с этим изменением?

В Release notes добавил, что это касается ChipsInput и ChipsSelect

@SevereCloud
Copy link
Contributor Author

Мы можем дать рекомендацию в документе по миграции как нужно переписать применение компонента ChipsInput / ChipsSelect, который потенциально "сломается" с этим изменением?

Мы можем сослаться на документацию реакта

@SevereCloud SevereCloud merged commit 2151ad4 into master Dec 3, 2025
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/BREAKING-CHANGE/changing-an-uncontrolled-input-to-be-controlled branch December 3, 2025 10:22
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 3, 2025
@inomdzhon inomdzhon linked an issue Dec 17, 2025 that may be closed by this pull request
1 task
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech] Поддержка React компилятора

2 participants