feat(ActionSheet): rename onClose to onClosed and add onClose#9285
Merged
EldarMuhamethanov merged 9 commits intomasterfrom Dec 23, 2025
Merged
Conversation
Contributor
e2e tests
|
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9285/69b5dab96c5f32a0b11429f6d3095ea4b414cea4/pkg/@vkontakte/vkui/_pkg.tgzCommit 69b5dab |
inomdzhon
reviewed
Dec 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9285 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 433 433
Lines 11769 11775 +6
Branches 4342 4343 +1
=======================================
+ Hits 11170 11176 +6
Misses 599 599
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inomdzhon
reviewed
Dec 18, 2025
Contributor
size-limit report 📦
|
inomdzhon
reviewed
Dec 22, 2025
inomdzhon
reviewed
Dec 22, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/action-sheet-rename-onClose-to-onClosed
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Переименовал обработчик onClose на onClosed и добавил onClose, который срабатывает перед анимацией закрытия
Release notes
Улучшения
onClose, который срабатывает перед началом анимации закрытия.ActionSheetOnCloseReason- причина закрытия, передаваемая вonClose.BREAKING CHANGE
onCloseпереименован наonClosed.onClosedпомечен как устаревший и будет удален вv10. Для получения причины закрытия лучше использоватьreason, передаваемый вonClose.ActionSheetOnCloseOptionsустарел и будет удален вv10.