fix: use camelCase for css modules names#9355
Merged
SevereCloud merged 1 commit intomasterfrom Jan 13, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9355/9c1f4837b3801f36e1633f441fd4b891282573dd/pkg/@vkontakte/vkui/_pkg.tgzCommit 9c1f483 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9355 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 439 439
Lines 11866 11867 +1
Branches 4385 4385
=======================================
+ Hits 11239 11240 +1
Misses 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inomdzhon
approved these changes
Jan 13, 2026
Contributor
inomdzhon
left a comment
inomdzhon
left a comment
There was a problem hiding this comment.
добавил майлстоун v8.0.0
SevereCloud
deleted the
SevereCloud/feat/use-camelCase-for-css-modules-names
branch
inomdzhon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit-тесты(линтеры)e2e-тестыДизайн-ревьюДокументация фичиRelease notesОписание
happy-css-modules с большой вероятностью в дальнейшем не будет поддерживаться. В место него рекомендуется использовать css-modules-kit. css-modules-kit не дает использовать названия классов которые являются невалидными в js. Также если мы будем переходить на именованные импорты(
* as styles), то нам необходимо иметь валидные js переменныеИзменения
Имена классов изменены в формате camelCase для
Release notes
Исправления
camelCaseформат