Skip to content

fix(Touch): onPointerDown preventDefault#9446

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/Touch/onPointerDown-preventDefault
Feb 6, 2026
Merged

fix(Touch): onPointerDown preventDefault#9446
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/Touch/onPointerDown-preventDefault

Conversation

@SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Feb 4, 2026


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

На андроиде нажатие на touch вызывает

  1. touchstart
  2. touchend
  3. mousestart
  4. mouseend

Из-за этого события onStart onEnd вызываются два раза

Изменения

Вызываем preventDefault для тач событий на onPointerDown. mousestart и mouseend не будут вызываться.

Release notes

Исправления

  • Touch: события onStart, onEnd могли два раза вызываться на Android

@SevereCloud SevereCloud requested a review from a team as a code owner February 4, 2026 14:51
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

size-limit report 📦

Path Size
JS 411.36 KB (+0.03% 🔺)
JS (gzip) 126.22 KB (+0.03% 🔺)
JS (brotli) 104.28 KB (+0.03% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 373.62 KB (0%)
CSS (gzip) 46.29 KB (0%)
CSS (brotli) 36.54 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 62a75c7

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9446/62a75c70b156dc47c67f8ccdb7006c2e28157b6e/pkg/@vkontakte/vkui/_pkg.tgz

Commit 62a75c7

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.77%. Comparing base (56abd37) to head (62a75c7).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Touch/Touch.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9446      +/-   ##
==========================================
- Coverage   94.78%   94.77%   -0.01%     
==========================================
  Files         440      440              
  Lines       11891    11894       +3     
  Branches     4387     4388       +1     
==========================================
+ Hits        11271    11273       +2     
- Misses        620      621       +1     
Flag Coverage Δ
unittests 94.77% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inomdzhon inomdzhon removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 5, 2026
@SevereCloud SevereCloud added this to VKUI Feb 6, 2026
@SevereCloud SevereCloud self-assigned this Feb 6, 2026
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Feb 6, 2026
@SevereCloud SevereCloud added this to the v7.11.4 milestone Feb 6, 2026
@SevereCloud SevereCloud added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 6, 2026
@SevereCloud SevereCloud merged commit dff7fd6 into master Feb 6, 2026
50 of 53 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Touch/onPointerDown-preventDefault branch February 6, 2026 15:03
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Feb 6, 2026
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 8.0-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 8.0-stable, выполните следующие действия:

  1. Создайте новую ветку от 8.0-stable и примените изменения используя cherry-pick
git stash # опционально
git fetch origin 8.0-stable
git checkout -b patch/pr9446 origin/8.0-stable

git cherry-pick --no-commit dff7fd650d0becf918206193797c08e2275f9d3e
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 8.0-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/pr9446
gh pr create --base 8.0-stable --title "patch: pr9446" --body "- patch #9446"

@vkcom-publisher
Copy link
Contributor

v7.11.4 🎉

SevereCloud added a commit that referenced this pull request Feb 9, 2026
@SevereCloud SevereCloud mentioned this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча ci:cherry-pick:v7 cmp:touch type:bug

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants