Skip to content

fix(ModalCard): animation enter-exit#9447

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/ModalCard/animation-enter-exit
Feb 6, 2026
Merged

fix(ModalCard): animation enter-exit#9447
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/ModalCard/animation-enter-exit

Conversation

@SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Feb 5, 2026

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

При анимации закрытия/открытия торчал часть ModalCard

Release notes

Исправления

  • ModalCard: исправлена анимация открытия/закрытия

@SevereCloud SevereCloud requested a review from a team as a code owner February 5, 2026 16:03
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 5, 2026
@SevereCloud SevereCloud removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

size-limit report 📦

Path Size
JS 411.23 KB (0%)
JS (gzip) 126.04 KB (0%)
JS (brotli) 104.1 KB (0%)
JS import Div (tree shaking) 811 B (0%)
CSS 373.68 KB (+0.02% 🔺)
CSS (gzip) 46.31 KB (+0.04% 🔺)
CSS (brotli) 36.59 KB (+0.12% 🔺)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 95e26a8

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.79%. Comparing base (8a21e5b) to head (95e26a8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9447   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files         441      441           
  Lines       11910    11910           
  Branches     4390     4390           
=======================================
  Hits        11290    11290           
  Misses        620      620           
Flag Coverage Δ
unittests 94.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9447/95e26a87653f7969c4bb3713343334688aaaeb72/pkg/@vkontakte/vkui/_pkg.tgz

Commit 95e26a8

@SevereCloud SevereCloud force-pushed the SevereCloud/fix/ModalCard/animation-enter-exit branch from 6f49bf0 to 8de26fe Compare February 6, 2026 07:32
@SevereCloud SevereCloud force-pushed the SevereCloud/fix/ModalCard/animation-enter-exit branch from 8de26fe to 95e26a8 Compare February 6, 2026 07:36
@SevereCloud SevereCloud added this to VKUI Feb 6, 2026
@SevereCloud SevereCloud self-assigned this Feb 6, 2026
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Feb 6, 2026
@SevereCloud SevereCloud added this to the v7.11.4 milestone Feb 6, 2026
@SevereCloud SevereCloud added ci:cherry-pick:v7 ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Feb 6, 2026
@SevereCloud SevereCloud merged commit ad057d7 into master Feb 6, 2026
91 of 101 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/ModalCard/animation-enter-exit branch February 6, 2026 15:01
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Feb 6, 2026
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 8.0-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 8.0-stable, выполните следующие действия:

  1. Создайте новую ветку от 8.0-stable и примените изменения используя cherry-pick
git stash # опционально
git fetch origin 8.0-stable
git checkout -b patch/pr9447 origin/8.0-stable

git cherry-pick --no-commit ad057d722075abf4bccd26943bb6897a1781df2b
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 8.0-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/pr9447
gh pr create --base 8.0-stable --title "patch: pr9447" --body "- patch #9447"

@vkcom-publisher
Copy link
Contributor

v7.11.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча ci:cherry-pick:v7 cmp:modal-card type:bug

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants