Skip to content

fix(SimpleGrid): gap default 0#9449

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/SimpleGrid/gap-default-0
Feb 6, 2026
Merged

fix(SimpleGrid): gap default 0#9449
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/SimpleGrid/gap-default-0

Conversation

@SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Feb 6, 2026

Описание

Flex может влиять на gap внутри компонента SimpleGrid
image

<Flex direction="column" gap={100}>
<SimpleGrid columns={3}>
  <Avatar size={48} initials="ДС" gradientColor="orange" />
  <Avatar size={48} initials="ИМ" gradientColor="yellow" />
  <Avatar size={48} initials="ВЖ" gradientColor="violet" />
</SimpleGrid>

Изменения

Делаем gap=0 по умолчанию

Release notes

Исправления

@SevereCloud SevereCloud requested a review from a team as a code owner February 6, 2026 14:36
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 6, 2026
@SevereCloud SevereCloud added type:bug cmp:simple-grid and removed ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Feb 6, 2026
@SevereCloud SevereCloud self-assigned this Feb 6, 2026
@SevereCloud SevereCloud added this to VKUI Feb 6, 2026
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Feb 6, 2026
@SevereCloud SevereCloud added this to the v8.0.0 milestone Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

size-limit report 📦

Path Size
JS 411.21 KB (-0.01% 🔽)
JS (gzip) 126.03 KB (-0.01% 🔽)
JS (brotli) 104.09 KB (-0.01% 🔽)
JS import Div (tree shaking) 811 B (0%)
CSS 373.62 KB (0%)
CSS (gzip) 46.29 KB (0%)
CSS (brotli) 36.54 KB (0%)

@SevereCloud SevereCloud force-pushed the SevereCloud/fix/SimpleGrid/gap-default-0 branch from e6c7ef9 to 32d395a Compare February 6, 2026 14:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 32d395a

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9449/32d395a4b5ca416485ac4c6f712c8d02576b44b1/pkg/@vkontakte/vkui/_pkg.tgz

Commit 32d395a

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.79%. Comparing base (8a21e5b) to head (32d395a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9449      +/-   ##
==========================================
- Coverage   94.79%   94.79%   -0.01%     
==========================================
  Files         441      441              
  Lines       11910    11909       -1     
  Branches     4390     4390              
==========================================
- Hits        11290    11289       -1     
  Misses        620      620              
Flag Coverage Δ
unittests 94.79% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud modified the milestones: v8.0.0, v7.11.4 Feb 6, 2026
@SevereCloud SevereCloud added ci:cherry-pick:v7 ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Feb 6, 2026
@SevereCloud SevereCloud merged commit c85c96e into master Feb 6, 2026
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/SimpleGrid/gap-default-0 branch February 6, 2026 15:00
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Feb 6, 2026
vkcom-publisher pushed a commit that referenced this pull request Feb 6, 2026
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 8.0-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 8.0-stable, выполните следующие действия:

  1. Создайте новую ветку от 8.0-stable и примените изменения используя cherry-pick
git stash # опционально
git fetch origin 8.0-stable
git checkout -b patch/pr9449 origin/8.0-stable

git cherry-pick --no-commit c85c96e305409db96dd8e83df2cefecccf8ab7d2
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 8.0-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/pr9449
gh pr create --base 8.0-stable --title "patch: pr9449" --body "- patch #9449"

SevereCloud added a commit that referenced this pull request Feb 6, 2026
@SevereCloud SevereCloud mentioned this pull request Feb 6, 2026
@vkcom-publisher
Copy link
Contributor

v7.11.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча ci:cherry-pick:v7 cmp:simple-grid type:bug

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants