Skip to content

fix: rm onPointerDown#9471

Merged
SevereCloud merged 3 commits intomasterfrom
SevereCloud/fix/rm-onPointerDown
Feb 11, 2026
Merged

fix: rm onPointerDown#9471
SevereCloud merged 3 commits intomasterfrom
SevereCloud/fix/rm-onPointerDown

Conversation

@SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Feb 10, 2026

Описание

Для события onPointerDown вызывается event.preventDefault(); чтобы на андроиде не присылались события мыши. Как оказалось это может блокировать фокусировку свайпбека на ios

Изменения

Удаляем onPointerDown, добавляем таймер в течении которого игнорируем события мыши

Release notes

Исправления

  • Свайпбек мог блокировать тач события

@SevereCloud SevereCloud requested a review from a team as a code owner February 10, 2026 10:02
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

size-limit report 📦

Path Size
JS 411.6 KB (+0.06% 🔺)
JS (gzip) 126.14 KB (+0.07% 🔺)
JS (brotli) 104.3 KB (+0.17% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 373.51 KB (0%)
CSS (gzip) 46.29 KB (0%)
CSS (brotli) 36.6 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 1458631

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9471/145863106e7d4707234d0fd4439e8d480f8533a0/pkg/@vkontakte/vkui/_pkg.tgz

Commit 1458631

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.78%. Comparing base (2cc4c9b) to head (1458631).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Touch/Touch.tsx 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9471      +/-   ##
==========================================
- Coverage   94.78%   94.78%   -0.01%     
==========================================
  Files         441      441              
  Lines       11912    11928      +16     
  Branches     4391     4394       +3     
==========================================
+ Hits        11291    11306      +15     
- Misses        621      622       +1     
Flag Coverage Δ
unittests 94.78% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud added this to VKUI Feb 10, 2026
@SevereCloud SevereCloud self-assigned this Feb 10, 2026
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Feb 10, 2026
@SevereCloud SevereCloud added this to the v7.11.5 milestone Feb 10, 2026
@SevereCloud SevereCloud force-pushed the SevereCloud/fix/rm-onPointerDown branch from 455de95 to 1458631 Compare February 10, 2026 18:20
@SevereCloud SevereCloud merged commit baf96ce into master Feb 11, 2026
28 of 29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/rm-onPointerDown branch February 11, 2026 08:08
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Feb 11, 2026
vkcom-publisher pushed a commit that referenced this pull request Feb 11, 2026
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 8.0-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 8.0-stable, выполните следующие действия:

  1. Создайте новую ветку от 8.0-stable и примените изменения используя cherry-pick
git stash # опционально
git fetch origin 8.0-stable
git checkout -b patch/pr9471 origin/8.0-stable

git cherry-pick --no-commit baf96ce2fd917db1db43cc5653154f37887ef1ab
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 8.0-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/pr9471
gh pr create --base 8.0-stable --title "patch: pr9471" --body "- patch #9471"

SevereCloud added a commit that referenced this pull request Feb 11, 2026
@SevereCloud SevereCloud mentioned this pull request Feb 11, 2026
@vkcom-publisher
Copy link
Contributor

v7.11.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча ci:cherry-pick:v7 cmp:touch type:bug

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants