-
Notifications
You must be signed in to change notification settings - Fork 43
Removed return so experiments always show … #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed return so experiments always show … #173
Conversation
… for improved clarity
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected], @hrishikesh2810. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #173 +/- ##
==========================================
Coverage 47.97% 47.97%
Complexity 243 243
==========================================
Files 22 22
Lines 1430 1430
==========================================
Hits 686 686
Misses 744 744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments on wording suggestions.
Beyond that, this works but is still probably not the best UX, though probably fine as a quick solution. I think long term it would be best to have a more guided approach to getting credentials set up when needed, instead of requiring users to go to a separate screen to do that
Co-authored-by: Darin Kotter <[email protected]>
Co-authored-by: Darin Kotter <[email protected]>
... Update messaging: replace "enable experiments" with "run experiments" for improved clarity
What?
Closes #170
Why?
How?
Testing Instructions
Install + activate the plugin
Visit the AI Experiments screen.
You should see the Experiments and admin message to promote to add keys