Fix null handling in preg_replace calls inside normalize_content() #177
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a potential bug where
preg_replace()failures could silently corrupt content in thenormalize_content()function. It's an edge case.Why?
If any of these
preg_replace()calls failed and returnednull, the code would continue withnullbeing cast to an empty string in subsequent operations. This could silently corrupt content without any indication of an error.How?
Added null coalescing operator to all three
preg_replace()calls innormalize_content().Not sure if we want to document the
@sincefor any modifications. If that's the case, please let me know, and I'll be happy to make the addition.