Address errors reported by Plugin Check

[pmbaldha]

Bug Description

Check whether the Performance Plugin fully complies with the Plugin Check (PCP) plugin. If not, make it comply

Steps to reproduce

1. Install and activate the Plugin Check (PCP) plugin from https://wordpress.org/plugins/plugin-check/.
2. Go to Admin Dashboard > Tools > Plugin Check.
3. Select the Performance Lab plugin.
4. Tick all Categories.
5. Click on the Check it! button.
6. See the warnings which can be resolved.

Screenshots

[westonruter]

Strange. Locally when I do composer run-script lint:performance-lab I don't get any errors, even though I see that there should be errors being flagged as PCP is detecting.

[westonruter]

I see the problem. The WordPress.Security.ValidatedSanitizedInput sniff and others are not included by default when using the WordPress-Extra ruleset. Working on a fix.

[westonruter]

@pmbaldha Some of the tests are false positives because they are checking the tests directory which is excluded from the build.

When checking with the build of the fixes in #2048 (performance-lab.zip) the results are as follows:

I believe these failures are expected given the nature of this core feature plugin.