Further refine Optimization Detective integration with build process and PL plugin

[westonruter]

This PR addresses non-blocking code review feedback from @felixarntz in #1079 (review).

• Eliminate reuse of output buffering from Optimization Detective in the Server-Timing functionality. See Merge Optimization Detective into trunk #1079 (comment).
• Remove parallel arg to PHPCS. I tested this and it doesn't seem to help here in Performance Lab. It may be due to the AMP plugin having many more PHP files being tested at once where it then makes an impact. I'm reverting in Further refine Optimization Detective integration with build process and PL plugin #1082.
• Locate the web-vitals.js script in a build directory, and update .gitignore and phpcs.xml.dist to ignore such build directories rather than the specific files that reside in them.
• Move detection/detect.js out of the subdirectory since it was the only file located now located there.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[thelovekesh]

I think it should be moved to phpcs.ruleset.xml and removed from anywhere else.

[thelovekesh]

Without parallel execution

➜  performance git:(update/optimization-detective-merge) ✗ composer lint:all          
> build-cs/vendor/bin/phpcs
............... 15 / 15 (100%)


Time: 541ms; Memory: 22MB

> build-cs/vendor/bin/phpcs '--' './plugins/auto-sizes' '--standard=./plugins/auto-sizes/phpcs.xml.dist'
.. 2 / 2 (100%)


Time: 88ms; Memory: 14MB

> build-cs/vendor/bin/phpcs '--' './plugins/dominant-color-images' '--standard=./plugins/dominant-color-images/phpcs.xml.dist'
..... 5 / 5 (100%)


Time: 176ms; Memory: 16MB

> build-cs/vendor/bin/phpcs '--' './plugins/embed-optimizer' '--standard=./plugins/embed-optimizer/phpcs.xml.dist'
.. 2 / 2 (100%)


Time: 96ms; Memory: 16MB

> build-cs/vendor/bin/phpcs '--' './plugins/optimization-detective' '--standard=./plugins/optimization-detective/phpcs.xml.dist'
............... 15 / 15 (100%)


Time: 488ms; Memory: 20MB

> build-cs/vendor/bin/phpcs '--' './plugins/speculation-rules' '--standard=./plugins/speculation-rules/phpcs.xml.dist'
..... 5 / 5 (100%)


Time: 167ms; Memory: 16MB

> build-cs/vendor/bin/phpcs '--' './plugins/webp-uploads' '--standard=./plugins/webp-uploads/phpcs.xml.dist'
...... 6 / 6 (100%)


Time: 288ms; Memory: 22MB

With parallel execution

➜  performance git:(update/optimization-detective-merge) ✗ composer lint:all
> build-cs/vendor/bin/phpcs
............... 15 / 15 (100%)


Time: 162ms; Memory: 12MB

> build-cs/vendor/bin/phpcs '--' './plugins/auto-sizes' '--standard=./plugins/auto-sizes/phpcs.xml.dist'
.. 2 / 2 (100%)


Time: 80ms; Memory: 12MB

> build-cs/vendor/bin/phpcs '--' './plugins/dominant-color-images' '--standard=./plugins/dominant-color-images/phpcs.xml.dist'
..... 5 / 5 (100%)


Time: 93ms; Memory: 12MB

> build-cs/vendor/bin/phpcs '--' './plugins/embed-optimizer' '--standard=./plugins/embed-optimizer/phpcs.xml.dist'
.. 2 / 2 (100%)


Time: 84ms; Memory: 12MB

> build-cs/vendor/bin/phpcs '--' './plugins/optimization-detective' '--standard=./plugins/optimization-detective/phpcs.xml.dist'
............... 15 / 15 (100%)


Time: 150ms; Memory: 12MB

> build-cs/vendor/bin/phpcs '--' './plugins/speculation-rules' '--standard=./plugins/speculation-rules/phpcs.xml.dist'
..... 5 / 5 (100%)


Time: 102ms; Memory: 12MB

> build-cs/vendor/bin/phpcs '--' './plugins/webp-uploads' '--standard=./plugins/webp-uploads/phpcs.xml.dist'
...... 6 / 6 (100%)


Time: 147ms; Memory: 12MB

[westonruter]

Oh right. That explains why I wasn't seeing a performance improvement since it wasn't in the shared ruleset.

[westonruter]

Moved in 5e55363

[thelovekesh]

Nice. Should we also move node_modules and vendor here?

[westonruter]

I don't think so because those directories are exclusively in the root of the repo and aren't also in the plugin subdirectories.

[thelovekesh]

@felixarntz @westonruter This file serves no purpose at the root of the project. Should we move it to bin/phpcs, just like Webpack utils?

[westonruter]

Good idea. Moved in 931ad51.

[mukeshpanchal27]

Thanks @westonruter for the PR.

In detect.js can we reuse const { log, formats } = require( '../lib/logger' ); and remove the console related function?

[westonruter]

In detect.js can we reuse const { log, formats } = require( '../lib/logger' ); and remove the console related function?

Actually no because this is a standalone unbuilt ESM module used on the frontend, not a CommonJS module used in node CLI.

[mukeshpanchal27]

In detect.js can we reuse const { log, formats } = require( '../lib/logger' ); and remove the console related function?

Actually no because this is a standalone unbuilt ESM module used on the frontend, not a CommonJS module used in node CLI.

Got it.

[felixarntz]

Thanks @westonruter!