Add missing uninstall.php to remove plugin's database option #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
approved these changes
Apr 12, 2024
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @westonruter. Approving, though minor nit-pick findings below.
Co-authored-by: Felix Arntz <[email protected]>
Co-authored-by: felixarntz <[email protected]>
mukeshpanchal27
approved these changes
Apr 12, 2024
Co-authored-by: Mukesh Panchal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparing for the PL 3.0.0 release, I was looking at the
builddirectory after runningnpm run build-plugins. I noticed that whilewebp-uploadshas anuninstall.phpnow (#1116), and anuninstall.phpis also present foroptimization-detective, there is none for Speculative Loading. This adds the missinguninstall.php, adapted from the one fromwebp-uploads.This also bumps the plugin version to 1.2.0 and updates the changelog.