Skip to content

Improve Settings->Media controls for Modern Image Formats #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 31 commits into from
Jun 5, 2024
Merged

Improve Settings->Media controls for Modern Image Formats #1273

westonruter merged 31 commits into from
Jun 5, 2024

Conversation

@adamsilverstein
Copy link
Member

@adamsilverstein adamsilverstein commented Jun 4, 2024

Summary

  • Improve settings when WebP support missing, or no when modern image support is available
  • Disable picture element form/description (at load) when JPEG output disabled
  • Dynamically toggle picture support form when JPEG output checkbox is toggled
  • Add a webp_uploads_is_generate_webp_and_jpeg_enabled helper

Fixes #1258

@adamsilverstein adamsilverstein added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Jun 4, 2024
@adamsilverstein adamsilverstein added this to the webp-uploads 2.0.0 milestone Jun 4, 2024
@github-actions
Copy link

github-actions bot commented Jun 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@adamsilverstein
Copy link
Member Author

adamsilverstein commented Jun 4, 2024

Adding some screenshots and a screencast:

No modern image formats supported:
no format supported

only avif supported:
only avif available

only WebP supported:
only webp available

screencast - toggling the JPEG output settings on and off
settings as gif

@adamsilverstein adamsilverstein changed the title Improve Settings->Media controls for Modern Images Improve Settings->Media controls for Modern Image Formats Jun 4, 2024
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
@westonruter westonruter mentioned this pull request Jun 4, 2024
Merged
@westonruter
Copy link
Member

westonruter commented Jun 4, 2024

@adamsilverstein As for disabling the picture element checkbox when the JPEG output checkbox is disabled, what do you think about hiding the picture element row instead? See adamsilverstein#1

adamsilverstein and others added 6 commits June 4, 2024 13:12
@adamsilverstein @westonruter
Update plugins/webp-uploads/settings.php
20be387 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein @westonruter
Update plugins/webp-uploads/settings.php
6f4ee81 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein @westonruter
Update plugins/webp-uploads/helper.php
b0e34d4 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein @westonruter
Update plugins/webp-uploads/settings.php
48691f5 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein @westonruter
Update plugins/webp-uploads/settings.php
9a1ff9d 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein @westonruter
Update plugins/webp-uploads/settings.php
6467f16 
Co-authored-by: Weston Ruter <westonruter@google.com>
@westonruter
Merge branch 'improve/image-settings' into improve/image-settings-hid…
71ec28b 
…e-picture-row

* improve/image-settings:
  Update plugins/webp-uploads/settings.php
  Update plugins/webp-uploads/settings.php
  Update plugins/webp-uploads/settings.php
  Update plugins/webp-uploads/settings.php
  Update plugins/webp-uploads/helper.php
  Update plugins/webp-uploads/settings.php
  Update plugins/webp-uploads/settings.php
@westonruter
Fix reference to renamed function
7a5f5b1
@westonruter
Remove is-dismissible
94080cb
@westonruter
Remove unused variable
ea7c215
@westonruter
Revert "Remove unused variable"
683b450 
This reverts commit ea7c215.
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
@westonruter
Copy link
Member

westonruter commented Jun 4, 2024

Maybe we can hide just the right column (checkbox/label/description) and replace it with a bit of text that says something like "JPEG fallback required to enable picture element" or something like that?

I like that idea. Like this? adamsilverstein#1 (comment)

westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
adamsilverstein and others added 5 commits June 4, 2024 14:21
@adamsilverstein @westonruter
Update plugins/webp-uploads/settings.php
a2e8584 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein
Merge branch 'trunk' into improve/image-settings
973b09e
@westonruter
Merge branch 'improve/image-settings' into improve/image-settings-hid…
5189c18 
…e-picture-row

* improve/image-settings:
  Update plugins/webp-uploads/settings.php
  Complete rename of webp_uploads_is_generate_webp_and_jpeg_enabled -> webp_uploads_is_jpeg_fallback_enabled
@westonruter
Fix logic inversion
377898d
@adamsilverstein
Merge pull request #1 from WordPress/improve/image-settings-hide-pict…
40a104f 
…ure-row

Show notice with picture element field
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
westonruter
westonruter approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more nits, but I'm pre-approving otherwise!

@westonruter westonruter requested a review from joemcgill June 4, 2024 21:15
westonruter and others added 5 commits June 4, 2024 14:20
@westonruter
Fix logic inversions for setting field
3933c10
@westonruter
Restore original selected override logic
e927824
@adamsilverstein @westonruter
Update plugins/webp-uploads/helper.php
059e916 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein @westonruter
Update plugins/webp-uploads/settings.php
d11fa3d 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein @westonruter
Update plugins/webp-uploads/settings.php
c317872 
Co-authored-by: Weston Ruter <westonruter@google.com>
@adamsilverstein
Copy link
Member Author

adamsilverstein commented Jun 5, 2024

Just a couple more nits, but I'm pre-approving otherwise!

Great, thanks for the feedback.

joemcgill
joemcgill approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but the code looks right to me. Nice update!

@westonruter westonruter merged commit bf5e1ad into WordPress:trunk Jun 5, 2024
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@joemcgill joemcgill joemcgill approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz felixarntz is a code owner

Assignees

No one assigned

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

webp-uploads 2.0.0

Development

Successfully merging this pull request may close these issues.

Improve Settings for Modern Image Formats

3 participants

@adamsilverstein @westonruter @joemcgill