Skip to content

Comments

Fix unit tests for webp-uploads with WordPress 6.7-alpha after sizes=auto landed#1533

Merged
felixarntz merged 1 commit intotrunkfrom
fix/webp-uploads-auto-sizes-test-failures
Sep 12, 2024
Merged

Fix unit tests for webp-uploads with WordPress 6.7-alpha after sizes=auto landed#1533
felixarntz merged 1 commit intotrunkfrom
fix/webp-uploads-auto-sizes-test-failures

Conversation

@westonruter
Copy link
Member

Summary

This fixes unit tests in 6.7-alpha after sizes=auto landed in core by avoiding sizes=auto from being added in the first place by making all the tested images not lazy-loaded.

Fixes #1532

This fixes unit tests in 6.7-alpha after sizes=auto landed in core
@westonruter westonruter added [Type] Bug An existing feature is broken [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) skip changelog PRs that should not be mentioned in changelogs labels Sep 12, 2024
@westonruter westonruter added this to the webp-uploads n.e.x.t milestone Sep 12, 2024
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter changed the title Use non-lazy images to test webp-uploads Fix unit tests for webp-uploads with WordPress 6.7-alpha after sizes=auto landed Sep 12, 2024
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @westonruter!

@felixarntz felixarntz merged commit 9d41ac3 into trunk Sep 12, 2024
@felixarntz felixarntz deleted the fix/webp-uploads-auto-sizes-test-failures branch September 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) skip changelog PRs that should not be mentioned in changelogs [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failing tests with WordPress trunk

2 participants