Allow disabling timestamp-based freshness checks by using negative TTL values

[ShyamGadde]

Summary

Fixes #1914

Relevant technical choices

• Modified OD_URL_Metric_Group_Collection constructor to accept negative freshness TTL values
• Updated OD_URL_Metric_Group::is_complete() to skip timestamp checks when freshness TTL is negative
• Updated the od_get_url_metric_freshness_ttl() function to allow negative values

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.09%. Comparing base (3d03c16) to head (b5e1892).
Report is 8 commits behind head on trunk.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk    #1940   +/-   ##
=======================================
  Coverage   71.08%   71.09%           
=======================================
  Files          86       86           
  Lines        6969     6970    +1     
=======================================
+ Hits         4954     4955    +1     
  Misses       2015     2015           

Flag	Coverage Δ
multisite	71.09% <100.00%> (+<0.01%)	⬆️
single	40.57% <40.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[westonruter]

Would it make sense to use:

Suggested change

	* @var int
	* @var int<-1, max>

And then throughout here.

[ShyamGadde]

Changed it in b5ef506.

[westonruter]

Per above, this could be:

Suggested change

	return (int) apply_filters( 'od_url_metric_freshness_ttl', WEEK_IN_SECONDS );
	$ttl = (int) apply_filters( 'od_url_metric_freshness_ttl', WEEK_IN_SECONDS );
	return max( -1, $ttl );

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ShyamGadde <shyamgadde@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[westonruter]

A key bit I realized was missing. Without this, URL Metrics will always attempt to be submitted again even.

[westonruter]

Thank you!