Add unit tests for Two_Factor_Provider::get_code().#522
Merged
dd32 merged 3 commits intoWordPress:masterfrom Feb 17, 2023
Merged
Add unit tests for Two_Factor_Provider::get_code().#522dd32 merged 3 commits intoWordPress:masterfrom
dd32 merged 3 commits intoWordPress:masterfrom
Conversation
Member
Author
|
This fails on WordPress 6.0 due to https://core.trac.wordpress.org/ticket/55194 Opened #523 to run unit tests against trunk as well. edit: I had included a check for WP < 6.1 and skipping the test, but I've thrown that out of this PR as it's not needed if we test with stable WordPress as in #524 |
dd32
force-pushed
the
add/tests-for-get_code
branch
from
a10cc25 to
d382826
Compare
Member
Author
|
In making this testable, since |
20 tasks
…ct character output Co-authored-by: Ian Dunn <ian@iandunn.name>
…r a string input of valid characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was split out of #518 as it's technically unrelated, and is failing for some reason in GitHub actions, but passing locally.
I can't really determine by looking at the code why it's failing though.