Fix Plugin Check Errors: MissingTranslatorsComment & MissingSingularPlaceholder#758
Merged
kasparsd merged 3 commits intoWordPress:masterfrom Feb 1, 2026
Merged
Fix Plugin Check Errors: MissingTranslatorsComment & MissingSingularPlaceholder#758kasparsd merged 3 commits intoWordPress:masterfrom
kasparsd merged 3 commits intoWordPress:masterfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kasparsd
approved these changes
Feb 1, 2026
| /* translators: 1: number of failed login attempts, 2: time since last failed attempt */ | ||
| _n( | ||
| 'WARNING: Your account has attempted to login without providing a valid two factor token. The last failed login occurred %2$s ago. If this wasn\'t you, you should reset your password.', | ||
| 'WARNING: Your account has attempted to login %1$s time without providing a valid two factor token. The last failed login occurred %2$s ago. If this wasn\'t you, you should reset your password.', |
Collaborator
There was a problem hiding this comment.
Looks like this requires updating the associated phpunit test case:
- Test_ClassTwoFactorCore::test_maybe_show_last_login_failure_notice
Failed asserting that 'WARNING: Your account has attempted to login 1 time without providing a valid two factor token. The last failed login occurred 5 seconds ago. If this wasn't you, you should reset your password.' contains "login without providing a valid two factor token"./var/www/html/wp-content/plugins/two-factor/tests/class-two-factor-core.php:630
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #757
What?
This PR intends to fix the MissingTranslatorsComment & MissingSingularPlaceholder Errors shown by the Plugin Check Plugin
Why?
This PR is necessary to resolve WordPress Coding Standards (PHPCS) i18n errors related to translatable strings with placeholders.
How?
The PR addresses these issues by:
Testing Instructions
Screenshots or screencast
Changelog Entry