Clarify TOTP setup instructions#763
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kasparsd
left a comment
There was a problem hiding this comment.
Had one optional suggestion with regards to the QR placement.
The copy looks good. We can always iterate on it.
providers/class-two-factor-totp.php
Outdated
| </li> | ||
| <li> | ||
| <?php esc_html_e( 'Scan this QR code using the app you installed:', 'two-factor' ); ?> | ||
| <?php /* QR image intentionally omitted. */ ?> |
There was a problem hiding this comment.
Could we actually place it here for semantics?
I believe list items <li> now support paragraph tags per HTML spec so we could add both the QR code and the follow-up paragraph (If scanning isn’t possible...) as list items here.
There was a problem hiding this comment.
@kasparsd can you give it another try? reworked and committed the changes.
Fixes #486
What?
The PR intends to improve user guidance on how to setup the TOTP.
Why?
The current setup text is quite basic and doesnt help unexperienced users enough to understand how the setup has to be done.
How?
After many contributors feedback in #486 this text is a draft to discuss.
Testing Instructions
Screenshots or screencast
Current State

New Proposal

Changelog Entry