Fix: Escape dots in filter-files-exclude-default regex#32
Merged
alphapapa merged 2 commits intoalphapapa:masterfrom Jan 6, 2024
Merged
Conversation
Owner
|
Thanks for catching that. I'll update the changelog and merge this when I have time. Thanks also for the kind words. I'm glad it's helpful to you. See also https://github.com/alphapapa/emacs-package-dev-handbook for more resources. |
154146c to
52c387d
Compare
c41b781 to
8fcedab
Compare
Owner
|
This is finally merged. Thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a trivial fix in the
filter-files-exclude-defaultregular expression: I escaped the dots where needed to make sure the regex doesn't accidentally match when it shouldn't.Before:
After:
I only noticed this because I'm working on a package named
foobar-dir-locals.eland hit this error:With the proposed fix in place, everything works as expected.
PS: Thanks so much for this script -- together with Steve Purcell's
package-lint, it's been a great help as I start writing and publishing my first packages 🙌