Fix "No files specified and not in a git repo" error on older bash versions#49
Merged
alphapapa merged 3 commits intoalphapapa:masterfrom Jul 10, 2024
Merged
Conversation
In older versions of bash (such as on macOS GitHub runners),
"${excludes[@]}" expands to a single empty argument (rather than no
arguments as intended), if it is declared as local without giving it a
value.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On bash-3.2 and older, this code passes a single empty "excludes" argument to
git ls-filesinstead of no arguments, which causes it to print nooutput (and the error is swallowed by
2>/dev/null):Since macOS runners on GitHub Actions have this old version of bash, I
personally think it would be convenient to fix this incompatibility
here, rather than forcing the CI workflows to install a new bash
version.