fix(posix): posix_kill crashes/kills other programs on null#68
Merged
fix(posix): posix_kill crashes/kills other programs on null#68
Conversation
When `$pid` in `posix_kill($pid, $signo)` is `null` it kills other programs like Firefox, Terminal, even Gnome Shell. This patch adds a null check to avoid this. Discovered via phpactor in Sublime Text: removing several folders in quick succession causes `posix_kill` to be called with `null`, for whatever reason, which causes a bunch of programs to crash. See phpactor/phpactor#2516
gerardroche
changed the title
|
hey @kelunik - do you think this could make sense? |
kelunik
reviewed
Feb 24, 2024
Member
|
@dantleech Yes of course, thanks for the PR and investigation! Merged and tagged. |
|
Thankyou! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
$pidinposix_kill($pid, $signo)isnullit kills other programs like Firefox, Terminal, even Gnome Shell. This patch adds a null check to avoid this.Discovered via phpactor in Sublime Text: removing several folders in quick succession causes
posix_killto be called withnull, for whatever reason, which causes a bunch of programs to crash.See phpactor/phpactor#2516