fix(cdk/table): throw when multiple row templates are used with virtual scrolling #32682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpl14
reviewed
Jan 21, 2026
crisbeto
force-pushed
the
32670/virtual-scroll-multi-rows
branch
2 times, most recently
from
335117d to
b814750
Compare
adolgachev
approved these changes
Jan 22, 2026
| throw getTableMultipleDefaultRowDefsError(); | ||
|
|
||
| if (typeof ngDevMode === 'undefined' || ngDevMode) { | ||
| if (this._virtualScrollEnabled() && this._rowDefs.some(def => def.when)) { |
Contributor
There was a problem hiding this comment.
I'd leave a comment with #32670 as context saying that the current logic doesn't support it, but it isn't necessarily infeasible with some future changes. Currently this gives the impression that they are fundamentally incompatible
andrewseguin
approved these changes
Jan 22, 2026
…al scrolling Since we reuse rows when virtual scrolling is enabled, supporting multiple row templates is tricky. These changes throw an error and update the docs.
crisbeto
force-pushed
the
32670/virtual-scroll-multi-rows
branch
from
b814750 to
4996089
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we reuse rows when virtual scrolling is enabled, supporting multiple row templates is tricky. These changes throw an error and update the docs.