Skip to content

fix(aria/combobox): Add announcement for empty results to autocomplete demo #32707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adolgachev merged 1 commit into from
Jan 27, 2026
Merged

fix(aria/combobox): Add announcement for empty results to autocomplete demo #32707

adolgachev merged 1 commit into from
Jan 27, 2026

Conversation

@adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Jan 26, 2026

Show how to incorporate an announcement with cdkAriaLive in the autocomplete example.

@pullapprove pullapprove bot requested review from andrewseguin and tjshiu January 26, 2026 19:57
@adolgachev adolgachev removed the request for review from andrewseguin January 26, 2026 19:57
@pullapprove pullapprove bot requested a review from andrewseguin January 26, 2026 19:57
@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Jan 26, 2026
@github-actions
Copy link

github-actions bot commented Jan 26, 2026 •
edited
Loading

Deployed dev-app for f40c733 to: https://ng-dev-previews-comp--pr-angular-components-32707-dev-um3n61fd.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev force-pushed the aria-autocomplete-announce branch from 4b8f4e3 to f40c733 Compare January 26, 2026 20:05
@adolgachev adolgachev changed the title fix(aria/autocomplete): Add announcement for empty results to demo fix(aria/combobox): Add announcement for empty results to autocomplete demo Jan 26, 2026
@adolgachev adolgachev removed the request for review from andrewseguin January 27, 2026 23:40
@adolgachev adolgachev added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 27, 2026
@adolgachev adolgachev merged commit 82a51f3 into angular:main Jan 27, 2026
27 checks passed
@adolgachev
Copy link
Contributor Author

adolgachev commented Jan 27, 2026

This PR was merged into the repository. The changes were merged into the following branches:

adolgachev added a commit that referenced this pull request Jan 27, 2026
@adolgachev
fix(aria/combobox): Add announcement for empty results to autocomplet…
1d9918a 
…e demo (#32707)

(cherry picked from commit 82a51f3)
@adolgachev adolgachev deleted the aria-autocomplete-announce branch January 27, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjshiu tjshiu tjshiu approved these changes

Assignees

No one assigned

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adolgachev @tjshiu