fix: restore skill filtering by agent permissions #7042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skills are now filtered based on agent permission rules when generating the tool description. This restores the ability to customize which skills are visible to each agent via frontmatter permissions. Changes: - Pass agent to ToolRegistry.tools() in session/prompt.ts - Filter skills using PermissionNext.evaluate() in skill.ts - Only show skills that are not explicitly denied Closes anomalyco#6857
Contributor
|
The following comment was made by an LLM, it may be inaccurate: ResultsI found one potentially related PR: Related PR:
Conclusion:No actual duplicates found. The current PR (#7042) is a fix for broken functionality rather than a duplicate effort. The only related PR is the earlier implementation (#5987) which this PR builds upon. |
Contributor
Author
|
@rekram1-node for your review 🙏 |
Collaborator
|
/review |
Contributor
|
lgtm |
ruuxi
pushed a commit
to ruuxi/ngmicode
that referenced
this pull request
Jan 7, 2026
This was referenced Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restores the ability to filter skills based on agent permission rules, which was broken after the permission system overhaul in PR #6319.
agenttoToolRegistry.tools()when building the tool registryPermissionNext.evaluate()before generating the skill tool descriptionExample Usage
Agents can now control which skills are visible via frontmatter:
This will only show
code-reviewandskill-creatorin that agent's available skills.Changes
packages/opencode/src/session/prompt.ts: Pass agent toToolRegistry.tools()packages/opencode/src/tool/skill.ts: Filter skills usingPermissionNext.evaluate()Closes #6857