fix: exclude 'none' variant for gpt-5.2-codex #7682
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes variant handling for OpenAI codex models by ensuring that codex models use a specific set of reasoning effort variants and explicitly excludes the "none" variant from gpt-5.2-codex.
Changes:
- Adds early return logic for codex models to prevent them from receiving "none" or "minimal" variants based on release dates
- gpt-*-codex models return ["low", "medium", "high"] variants
- gpt-5.2-codex specifically returns ["low", "medium", "high", "xhigh"] variants
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fwang
pushed a commit
to lifefloating/opencode
that referenced
this pull request
Jan 10, 2026
zerone0x
pushed a commit
to zerone0x/opencode
that referenced
this pull request
Jan 12, 2026
zerone0x
pushed a commit
to zerone0x/opencode
that referenced
this pull request
Jan 12, 2026
athal7
pushed a commit
to athal7/opencode
that referenced
this pull request
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7680
What does this PR do?
adds explicit variant handling for codex models:
gpt-*-codex→["low", "medium", "high"]gpt-5.2-codex→["low", "medium", "high", "xhigh"]