fix: await auth.set to prevent race condition when setting API key #8075
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
When manually entering an API key via /model dialog, the auth.set() call was not being awaited, causing a race condition where instance.dispose() and sync.bootstrap() would run before the auth was saved to disk. This resulted in the API key not being loaded after entry, requiring a restart to pick up the key.
darshkpatel
force-pushed
the
fix/await-auth-set
branch
from
582f080 to
0449b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8073
awaitto theauth.set()call in the/modeldialog to ensure the API key is persisted beforeinstance.dispose()andsync.bootstrap()runRoot Cause
The
auth.set()call was not being awaited, causing a race condition where the bootstrap would happen before the auth data was written to disk. This resulted in the API key not being loaded after entry, requiring a restart.Reproduction of the bug
opencode-apikey-bug.mp4
Bug fix
opencode-apikey-bugfix.mp4