-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[AIRFLOW-5749] Support the "blocks" component for the Slack operators #6418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Change looks good, but test failrues are I think fixed on master. Can you rebase on to latest master? |
00e09e0 to
a2966ce
Compare
|
@ashb I'm done! |
|
I found a lint error and fixed it |
|
Oh we have two of those #6402 |
|
Oh, I didn't see that :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please add [AIRFLOW-4162] to the commit title and a Co-authored-by: to the commit message, because it refers to the same feature. Thanks.
cc @bskim45
|
Sure! I'll change the commit message. |
51ab273 to
e67b460
Compare
|
Thank you guys for being so collaborative :) I can merge it when ✔️ |
Codecov Report
@@ Coverage Diff @@
## master #6418 +/- ##
==========================================
- Coverage 84.25% 83.91% -0.35%
==========================================
Files 627 627
Lines 36525 36529 +4
==========================================
- Hits 30775 30653 -122
- Misses 5750 5876 +126
Continue to review full report at Codecov.
|
…lack operators (#6418) Co-authored-by: bskim45 <[email protected]>
…lack operators (#6418) Co-authored-by: bskim45 <[email protected]>
…lack operators (#6418) Co-authored-by: bskim45 <[email protected]>
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Slack clients v1.x.x also does support "blocks".