Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 82.47% 82.47%
=======================================
Files 162 162
Lines 43414 43414
=======================================
Hits 35805 35805
Misses 7609 7609 Continue to review full report at Codecov.
|
alamb
left a comment
There was a problem hiding this comment.
Looks like an improvement to me. I have a few suggestions, but I think it would be fine to merge as is too
| **Describe the bug** | ||
| A clear and concise description of what the bug is. | ||
|
|
There was a problem hiding this comment.
I like to try and lead people away from a free form description of bugs as that often ends up more confusing (to me)
What would you think about the sections:
- To Reproduce
- Expected Behavior
- Actual Behavior
- Additional Context
There was a problem hiding this comment.
Yes, that looks good to me.
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
jorgecarleitao
left a comment
There was a problem hiding this comment.
Awesome, great write up and all very sensible. 👍
PrimitiveArray::from_trusted_len_iter to take an ExactSizeIterator
#8564
Here are suggested issue templates for bugs and features, as well as a PR template that will prompt users to enter the issue that the PR is closing.