feat: deterministic metadata encoding#7437
Merged
alamb merged 3 commits intoapache:mainfrom May 1, 2025
Merged
Conversation
Member
Author
|
I currently based this off 54.3.1 but I will updated it to |
ee273f6 to
5027767
Compare
Member
Author
|
Rebased on main, ready for review. |
alamb
approved these changes
Apr 28, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @timsaucer -- I think this PR makes sense to me
Can you please file a ticket (it makes for better release notes / easier to understand what changed)
Member
Author
|
@alamb Thank you for the review. I have added an issue as requested, but as I am not a committer on arrow-rs I will need someone else to merge this. |
Contributor
etseidl
approved these changes
Apr 28, 2025
Contributor
|
Thanks again @timsaucer and @etseidl |
teh-cmc
added a commit
to rerun-io/arrow-rs
that referenced
this pull request
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The ordering of metadata is not consistent since it uses a HashMap. It can be useful in unit tests to verify an output from a known hash of it's serialized values. With metadata this is not consistent.
What changes are included in this PR?
Adds ordering to the hashmap keys when encoding.
Are there any user-facing changes?
No.
Example
If you run this example multiple times, you will see the encoding changes from run to run based on the non-deterministic ordering of the hashmap iterator.