[Variant] Add nullable arg to StructArrayBuilder::with_field#8342
Merged
alamb merged 3 commits intoapache:mainfrom Sep 15, 2025
Merged
[Variant] Add nullable arg to StructArrayBuilder::with_field#8342alamb merged 3 commits intoapache:mainfrom
alamb merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
CC @alamb @codephage2020 -- should be a quickie |
Contributor
|
It looks like there is a conflict in this PR |
Contributor
Author
Some kind of github confusion, methinks? The git cli handled it fine 🤷 |
Contributor
|
Merged up to resolve a conflict per @codephage2020 |
Contributor
|
Thanks @scovich and @codephage2020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
StructArrayBuilder::with_fieldis currently hard-wired to assume the field will be nullable. This is unhelpful when adding non-nullable fields such as variant ametadatacolumn.What changes are included in this PR?
Add a third parameter,
nullable.Are these changes tested?
The builder is heavily used by unit tests, which have been adjusted to pass the new param.
Are there any user-facing changes?
No.