[Variant] [Shredding] Support typed_access for Utf8 and BinaryView#8364
Merged
alamb merged 5 commits intoapache:mainfrom Sep 17, 2025
Merged
[Variant] [Shredding] Support typed_access for Utf8 and BinaryView#8364alamb merged 5 commits intoapache:mainfrom
alamb merged 5 commits intoapache:mainfrom
Conversation
klion26
approved these changes
Sep 17, 2025
Member
klion26
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution.
Contributor
|
I just ran the new integration test and it fails (as expected) with this PR as we have enabled some new features. cargo test --all-features variant_integrationFails like this: I just pushed a commit to fix the CI to run the tests, and will push another one to fix the tests |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Utf8andBinaryView#8333Rationale for this change
See Issue
What changes are included in this PR?
Support typed_access for Utf8 and BinaryView
Are these changes tested?
Yes
Are there any user-facing changes?
N/A. Variant support still in development