Add example of parsing field names as VariantPath#8945
Merged
alamb merged 2 commits intoapache:mainfrom Dec 10, 2025
Merged
Conversation
klion26
approved these changes
Dec 4, 2025
Member
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
Thanks for the improvement, LGTM
mhilton
reviewed
Dec 4, 2025
| /// assert_eq!(path, path3); | ||
| /// ``` | ||
| /// | ||
| /// # Example: From Dot notation strings |
Contributor
There was a problem hiding this comment.
My immediate question from this is "is there an escape mechanism to allow for "." in a field name?". I checked and the answer's no. That's fine but it might be worth a note.
Contributor
Author
There was a problem hiding this comment.
I'll do even better than that and instead 🎣 for real support:
mhilton
approved these changes
Dec 4, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ShreddedSchemaBuilder) #8940Rationale for this change
When reviewing #8940 it wasn't clear you could create a
VariantPathfrom a stringThus let's add an example to the documentation
What changes are included in this PR?
Add an example to the documentation
Are these changes tested?
Yes, by CI
Are there any user-facing changes?
Docs only, no functional change