Improve parquet BinaryView / StringView decoder performance (up to -35%)#9236
Merged
Dandandan merged 19 commits intoapache:mainfrom Jan 22, 2026
Merged
Improve parquet BinaryView / StringView decoder performance (up to -35%)#9236Dandandan merged 19 commits intoapache:mainfrom
Dandandan merged 19 commits intoapache:mainfrom
Conversation
Contributor
Author
|
run benchmark arrow_reader arrow_reader_clickbench |
|
🤖 |
Contributor
Author
|
run benchmark arrow_reader arrow_reader_clickbench |
Dandandan
commented
Jan 21, 2026
| while self.offset < self.buf.len() && read != to_read { | ||
| if self.offset + 4 > self.buf.len() { | ||
| let mut utf8_validation_begin = offset; | ||
| for _ in 0..to_read { |
Contributor
Author
There was a problem hiding this comment.
Somehow using extend here makes things slower (even though I can see in the profile it now uses the trusted len path instead of Vec:push
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
Dandandan
changed the title
Dandandan
changed the title
Contributor
Author
|
run benchmark arrow_reader |
Dandandan
commented
Jan 21, 2026
| let read = self.decoder.read(len, |keys| { | ||
| output | ||
| .views | ||
| .extend(keys.iter().map(|k| match dict.views.get(*k as usize) { |
Contributor
Author
There was a problem hiding this comment.
This is the largest optimization.
Dandandan
commented
Jan 21, 2026
| } | ||
|
|
||
| if self.validate_utf8 { | ||
| if VALIDATE_UTF8 { |
Contributor
Author
There was a problem hiding this comment.
I think this is the main improvement for the plain decoder
|
🤖: Benchmark completed Details
|
|
🤖 |
Contributor
Those are some pretty nice improvements |
Contributor
Author
|
Also |
|
🤖: Benchmark completed Details
|
|
🤖 |
alamb
approved these changes
Jan 21, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I reviewed this carefully and the changes make sense to me -- thank you @Dandandan
| let len = u32::from_le_bytes(len_bytes); | ||
|
|
||
| let start_offset = self.offset + 4; | ||
| let len = u32::from_le_bytes(unsafe { *(buf.as_ptr().add(offset) as *const [u8; 4]) }); |
Contributor
There was a problem hiding this comment.
The idea here is to save a bounds check for the length, right?
Contributor
Author
There was a problem hiding this comment.
Yeah... although I probably need to recheck whether it makes a difference.
|
🤖: Benchmark completed Details
|
Dandandan
changed the title
Contributor
Author
|
run benchmark arrow_reader arrow_reader_clickbench |
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
Contributor
Author
|
|
🤖: Benchmark completed Details
|
Contributor
|
This is so good |
alamb
reviewed
Jan 22, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good other than a very subtle bug related to utf8 validation.
alamb
added a commit
that referenced
this pull request
Jan 22, 2026
# Which issue does this PR close? - Related to #9236 # Rationale for this change While reviewing #9236 from @Dandandan I found (with codex's help) that the UTF8 validation for long strings was slightly different. This test shows the problem (it passes on main but fails on the current PR) # What changes are included in this PR? Add new test # Are these changes tested? yes only tests # Are there any user-facing changes? No
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Contributor
Author
|
🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Details
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?