ARROW-11313: [Rust] Fixed size_hint#9258
Closed
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:fix_size_hint
Closed
ARROW-11313: [Rust] Fixed size_hint#9258jorgecarleitao wants to merge 1 commit intoapache:masterfrom jorgecarleitao:fix_size_hint
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:fix_size_hint
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9258 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 215 215
Lines 51867 51891 +24
=======================================
+ Hits 42329 42353 +24
Misses 9538 9538
Continue to review full report at Codecov.
|
alamb
approved these changes
Jan 19, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
This looks consistent with https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.size_hint to me. 👍 @jorgecarleitao
I also found another implementation of size_hint but that seems to be doing the right thing: https://github.com/alamb/arrow/blob/master/rust/arrow/src/util/bit_chunk_iterator.rs#L156
paddyhoran
approved these changes
Jan 19, 2021
Contributor
|
I merged this branch locally and ran the tests and everything looked good 👍 |
kszucs
pushed a commit
that referenced
this pull request
Jan 25, 2021
`size_hint` should return the remaining items, not the total number of items. Closes #9258 from jorgecarleitao/fix_size_hint Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
size_hintshould return the remaining items, not the total number of items.