Skip to content

Force SSL for all connections of Acceptor#2231

Merged
wwbmmm merged 3 commits intoapache:masterfrom
chenBright:force_ssl
Jun 25, 2023
Merged

Force SSL for all connections of Acceptor#2231
wwbmmm merged 3 commits intoapache:masterfrom
chenBright:force_ssl

Conversation

@chenBright
Copy link
Contributor

@chenBright chenBright commented May 3, 2023

What problem does this PR solve?

Issue Number: fix #2194

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright added the feature new feature label May 3, 2023
@wwbmmm
Copy link
Contributor

wwbmmm commented May 5, 2023

这样会不会内置服务也不能用了?

@chenBright
Copy link
Contributor Author

服务应该要提供浏览器信任的SSL证书,内置服务才能用了

@wwbmmm
Copy link
Contributor

wwbmmm commented May 5, 2023

如果指定了internal_port,将内置服务启动在单独的端口,能否只对主端口强制SSL,internal_port不生效呢?
也就是说,强制SSL这个flag应该是一个Acceptor级别的,而不是全局的

@chenBright
Copy link
Contributor Author

这样可以

@chenBright chenBright changed the title Force SSL for all connections Force SSL for all connections of Acceptor May 5, 2023
@chenBright
Copy link
Contributor Author

@wwbmmm 修改为按Acceptor级别强制使用SSL

@wwbmmm
Copy link
Contributor

wwbmmm commented May 8, 2023

LGTM

@wwbmmm wwbmmm merged commit bc6f30d into apache:master Jun 25, 2023
@chenBright chenBright deleted the force_ssl branch June 25, 2023 06:42
@chenBright chenBright linked an issue Jun 25, 2023 that may be closed by this pull request
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
* Force SSL for all connections

* Force SSL for all connections of Acceptor

* Force SSL option in ServerOptions
gavinchou pushed a commit to apache/doris that referenced this pull request Sep 5, 2025
github-actions bot pushed a commit to apache/doris that referenced this pull request Sep 5, 2025
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force SSL for all connections if user enabled SSL

2 participants

Comments