Incorrect error message for decimal with scale while input value is out of bound

[waitingkuo]

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

❯ select 1::decimal(1, 1);
ArrowError(InvalidArgumentError("10 is too large to store in a Decimal128 of precision 1. Max is 9"))

❯ select 10::decimal(2, 1);
ArrowError(InvalidArgumentError("100 is too large to store in a Decimal128 of precision 2. Max is 99"))

Expected behavior
A clear and concise description of what you expected to happen.

something like

❯ select 10::decimal(2, 1);
ArrowError(InvalidArgumentError("10 is too large to store in a Decimal128 of precision 2  with scale 1. Max is 9.9"))

Additional context
Add any other context about the problem here.

[HaoYang670]

Is this a parsing error of decimal value? cc @liukun4515

[liukun4515]

@waitingkuo
The error message is not right, we just print the value of i128 for the precision, and don't consider the scale value.

[HaoYang670]

Not sure which PR affects it, but this is what I got with the latest commit in the master branch:

❯ select 1::decimal(1,1);
+----------+
| Int64(1) |
+----------+
| .1       |
+----------+
1 row in set. Query took 0.004 seconds.
❯ select 10::decimal(2,1);
+-----------+
| Int64(10) |
+-----------+
| 1.0       |
+-----------+

[HaoYang670]

cc @andygrove

[drauschenbach]

Fast-forward a few years, and this behavior is back.

select 1::decimal(1, 1);
Arrow error: Invalid argument error: 10 is too large to store in a Decimal128 of precision 1. Max is 9

select 10::decimal(2, 1);
Arrow error: Invalid argument error: 100 is too large to store in a Decimal128 of precision 2. Max is 99

[Jefffrey]

See upstream issue in arrow-rs: apache/arrow-rs#8382