helm/doris-operator: add support for deploy resources#462
Merged
catpineapple merged 1 commit intoapache:masterfrom Dec 11, 2025
Merged
helm/doris-operator: add support for deploy resources#462catpineapple merged 1 commit intoapache:masterfrom
catpineapple merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@catpineapple a couple of eyes in this PR will be appreciated too. Thanks! |
Contributor
Author
|
friendly ping @catpineapple |
Contributor
Author
|
desperate ping @catpineapple |
catpineapple
approved these changes
Dec 11, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add support to setup resources in the dosris-operator helm chart.
Problem Summary:
The chart exposes resources configuration fields in
values.yamlunderdorisOperator.resources, but the Deployment template always used the "hard-coded" default values instead of the user-provided overrides.This issue can be reproduced as follows:
The values coming from
values.yamlare ignored, and the Deployment always renders the default resources.After applying the template changes included in this PR, Helm correctly renders the user-configured resources:
This confirms that the chart now properly respects user-defined resource settings from values.yaml
Release note
Add support to setup resources in the dosris-operator helm chart.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)